[onboarding] make TrustDirectoryWidget aware of non-git repos #2977
+397
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dget Summary: I have read the CLA Document and I hereby sign the CLA Adds tests for openai#2585 but on the TrustDirectoryWidget level (tests were added in `git_info.rs`) Commits later in this stack change this code so tests on this level help verify correctness a layer up. Test Plan: `cargo test && cargo clippy --tests && cargo fmt -- --config imports_granularity=Item`
…ryWidget if in a git repo Summary: I have read the CLA Document and I hereby sign the CLA This commit adds a short circut in `handle_trust()` - there is no need to call `resolve_root_git_project_for_trust()`, which spawns a `git` subprocess, if we're not in a git repo in the first place. Test Plan: `cargo test && cargo clippy --tests && cargo fmt -- --config imports_granularity=Item`
Summary: I have read the CLA Document and I hereby sign the CLA This commit teaches TrustDirectoryWidget to check for more than just Git repos. I was using codex with a repo cloned with [Sapling](https://sapling-scm.com/) and got shown Test Plan: `cargo test && cargo clippy --tests && cargo fmt -- --config imports_granularity=Item` `cargo run --bin codex -- --model gpt-5 --full-auto -c model_reasoning_effort="high"` before: trust prompt shows in Sapling cloned repo after: trust prompt doesn't appear in Sapling cloned repo
|
All contributors have signed the CLA ✍️ ✅ |
|
recheck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I have read the CLA Document and I hereby sign the CLA
This commit teaches TrustDirectoryWidget to check for more than just Git repos. I was using codex with a repo cloned with Sapling and got a prompt saying "Since this folder is not version controlled, we recommend requiring...". This is incorrect - I'm using Sapling so the directory is version controlled, just not with Git.
Test Plan:
cargo test && cargo clippy --tests && cargo fmt -- --config imports_granularity=Itemcargo run --bin codex -- --model gpt-5 --full-auto -c model_reasoning_effort="high"before: trust prompt shows in Sapling cloned repo
after: trust prompt doesn't appear in Sapling cloned repo
Stack created with Sapling. Best reviewed with ReviewStack.