feat: add openstack nova as cloud entities #2622
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paulo Dias <[email protected]>
Signed-off-by: Paulo Dias <[email protected]>
There was a problem hiding this comment.
I feel we need should be progressing the discussion about what is the cloud namespace for. For me some of these would be better addressee via #2367
Comment on lines
+35
to
+38
| - id: 'openstack' | ||
| value: 'openstack' | ||
| brief: 'Openstack' | ||
| stability: development |
There was a problem hiding this comment.
Openstack is not a provider.
Comment on lines
+270
to
+273
| - id: openstack_nova | ||
| value: 'openstack_nova' | ||
| brief: Openstack Compute (Nova) | ||
| stability: development |
There was a problem hiding this comment.
Check id to be compliant with latest conventions.
|
@thompson-tomo, nothing against it, but I also think you are missing the Let's wait for the reviewers also 👍 |
|
Agree and that is because I had never heard of openstack prior to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
Changes
This PR introduces a new
cloud.providerandcloud.platformvalues for OpenStack (openstack) and OpenStack Compute (Nova) (openstack_nova).These additions align with the new OpenStack Nova resource detection processor in the Collector and ensure consistent attribute naming across all resources.
Merge requirement checklist
[chore]