Skip to content

Conversation

vitorvasc
Copy link
Member

@vitorvasc vitorvasc commented Aug 19, 2025

@vitorvasc vitorvasc added the CI/infra CI & infrastructure label Aug 19, 2025
@vitorvasc vitorvasc force-pushed the infra_add-refcache-registry-version-workflow branch from a366673 to f8a0a68 Compare August 19, 2025 22:12
@vitorvasc vitorvasc marked this pull request as ready for review August 20, 2025 10:51
@vitorvasc vitorvasc requested a review from a team as a code owner August 20, 2025 10:51
@vitorvasc vitorvasc self-assigned this Aug 27, 2025
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great that you're working on this! @vitorvasc 🙌🏻

Have you tested these changes locally?

I don't know enough about .github/workflows/scripts/update-registry-versions.sh, so I'll let @svrnm review the changes made to that file.

Regarding version-in-file.sh: take a look at scripts/auto-update/all-versions.sh, and you'll see that the version-in-file.sh script can be run many times. We'll want to fix the refcache only once at the end when all versions will have been checked, and only if there have been some version changes.

Thanks!

@chalin chalin force-pushed the infra_add-refcache-registry-version-workflow branch from be338a9 to 9ad2d33 Compare August 27, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants