Skip to content

Add instructions for Java app servers #3459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 43 commits into from
Feb 20, 2024
Merged

Add instructions for Java app servers #3459

merged 43 commits into from
Feb 20, 2024

Conversation

theletterf
Copy link
Member

@theletterf theletterf commented Oct 31, 2023 •
edited by chalin
Loading

@theletterf theletterf requested review from a team October 31, 2023 11:21
@theletterf theletterf mentioned this pull request Oct 31, 2023
Closed
@theletterf
Copy link
Member Author

+CC @breedx-splk

@tylerbenson tylerbenson mentioned this pull request Oct 31, 2023
Closed
@theletterf theletterf marked this pull request as draft October 31, 2023 16:46
@theletterf
Copy link
Member Author

We've to check some things first, so turning this into draft for now. Please do not merge until ready.

chalin
chalin reviewed Oct 31, 2023
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a few comments since you've marked this as WIP.

Before you worked further on this, I wanted to suggest switching to the use of tabbed panes, as illustrated below. This will provide a better UX given that tab choice is persisted.

@chalin
Copy link
Contributor

chalin commented Oct 31, 2023

Solves #3154

FYI, it's better to write either "Fixes X" or "Closes X" so that GH can automatically close issue X when the PR is merged.

@chalin chalin force-pushed the theletterf-java-server-instructions branch from 7936ec9 to 176bdc8 Compare October 31, 2023 21:37
theletterf and others added 9 commits November 6, 2023 12:14
@theletterf
Merge branch 'main' into theletterf-java-server-instructions
a3db0f5
@theletterf @chalin
Update content/en/docs/instrumentation/java/automatic/servers.md
86f3870 
Co-authored-by: Patrice Chalin <[email protected]>
@theletterf @chalin
Update content/en/docs/instrumentation/java/automatic/servers.md
96951e9 
Co-authored-by: Patrice Chalin <[email protected]>
@theletterf @chalin
Update content/en/docs/instrumentation/java/automatic/servers.md
3c6a9d7 
Co-authored-by: Patrice Chalin <[email protected]>
@theletterf @chalin
Update content/en/docs/instrumentation/java/automatic/servers.md
571c746 
Co-authored-by: Patrice Chalin <[email protected]>
@theletterf @chalin
Update content/en/docs/instrumentation/java/automatic/servers.md
8d2c7ac 
Co-authored-by: Patrice Chalin <[email protected]>
@theletterf
Merge branch 'theletterf-java-server-instructions' of github.com:thel…
c830f77 
…etterf/opentelemetry.io into theletterf-java-server-instructions
@theletterf
Rename
c689677
@theletterf
Lint
05f2a93
@theletterf theletterf marked this pull request as ready for review November 6, 2023 11:21
chalin
chalin reviewed Nov 6, 2023
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another pass. See inline comments.

@breedx-splk
Copy link
Contributor

@theletterf Where is this now? 🙏🏻

@theletterf
Copy link
Member Author

Still discussing with Legal... Will let you know! Thanks for the patience!

@theletterf theletterf mentioned this pull request Dec 4, 2023
Closed
@svrnm
Copy link
Member

svrnm commented Jan 18, 2024

do we have any updates here?

@theletterf theletterf self-assigned this Jan 30, 2024
@theletterf
Copy link
Member Author

Got the OK to publish this, at last! :)

@svrnm
Copy link
Member

svrnm commented Feb 20, 2024

@open-telemetry/java-approvers PTAL!

@svrnm svrnm removed the blocked label Feb 20, 2024
laurit
laurit reviewed Feb 20, 2024
View reviewed changes
@theletterf
Copy link
Member Author

/fix:all

@github-actions GitHub Actions
Copy link
Contributor

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/7971702849

@theletterf theletterf requested a review from laurit February 20, 2024 10:10
@theletterf theletterf dismissed cartermp’s stale review February 20, 2024 10:11

Requires re-review

tylerbenson
tylerbenson reviewed Feb 20, 2024
View reviewed changes
@theletterf
Copy link
Member Author

@open-telemetry/docs-maintainers I think we're good to go.

@cartermp
Copy link
Contributor

Yay, finally!

@cartermp cartermp merged commit 88fd9df into open-telemetry:main Feb 20, 2024
@svrnm
Copy link
Member

svrnm commented Feb 21, 2024

🎉 great to see this being merged :-)

@tylerbenson
Copy link
Member

Thanks for the work on this. Nice addition to the site!

@trask
Copy link
Member

trask commented Feb 21, 2024

thanks @theletterf (and Splunk legal)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svrnm svrnm svrnm approved these changes

@laurit laurit laurit approved these changes

@cartermp cartermp cartermp approved these changes

@chalin chalin Awaiting requested review from chalin

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees

@theletterf theletterf

Labels
sig:java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs for instrumenting various App Servers
9 participants
@theletterf @chalin @cartermp @breedx-splk @svrnm @tylerbenson @trask @laurit @opentelemetrybot