async await http instrumentation #849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds AsyncTaskDelegate to properly handle completion callbacks for async/await URLSession methods on iOS 15+/macOS 12+, ensuring spans are completed and telemetry is accurate. Updates tests to assert correct callback invocation for async/await APIs.
martin308
requested review from
nachoBonafonte,
bryce-b,
vvydier and
ArielDemarco
as code owners
nachoBonafonte
approved these changes
Jul 5, 2025
This was referenced Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found an issue with some of the networking instrumentation.
Added some tests to reproduce the issue and a potential fix.