Remove old metrics and replace with StableMetrics #809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryce-b
requested review from
nachoBonafonte,
vvydier and
ArielDemarco
as code owners
bryce-b
force-pushed
the
metrics-type-refactor
branch
from
d93f1b7 to
58bde17
Compare
…meterBuilder() method Resolved this by added a NoopStableMeterProviderBuilder that resolves to a StableMeterProviderBuilder once a reader is added.
bryce-b
force-pushed
the
metrics-type-refactor
branch
from
97d4108 to
7932374
Compare
bryce-b
force-pushed
the
metrics-type-refactor
branch
from
b39242a to
da0dbc4
Compare
bryce-b
commented
Jun 26, 2025
| } | ||
|
|
||
| public func encode(to encoder: any Encoder) throws { | ||
| var container = try encoder.container(keyedBy: CodingKeys.self) |
nachoBonafonte
approved these changes
Jul 1, 2025
There was a problem hiding this comment.
Really great work, it has really take long getting here but you did it, congrats!!!
There is one thing I am not sure if should also be added or what are the drawback, just remove all the Stable from the name , eg StableMeterProviderSdk -> MeterProviderSdk and keep a type alias with the Stable prefix, like:
public typealias StableMeterProvider = MeterProvider
public protocol MeterProvider: AnyObject {
and
public typealias StableMeterProviderSdk = MeterProviderSdk
public class MeterProviderSdk: MeterProvider {
But it can also be done in a separate PR.
|
@nachoBonafonte I thought that might be too noisy to include in this PR--I was trying to make it a little easier to review. Next PR will remove the term Note: I want to do one more release before merging this PR |
|
@bryce-b Works for me!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completely removes the old metrics and replaces the tests and various usages with StableMetrics
including:
Other details:
metrics/except undermetrics/stable)metrics/stablehave been moved up a level intometricsPointDatachild objects have been extended to supportcodableto enable their use with Sources/Exporters/Persistence/PersistenceMetricExporterDecorator.swifthttps://github.com/open-telemetry/opentelemetry-swift/pull/809/files#diff-a45fa4ec76dac519209de328dcdaea417eb2cf599cbc9b4d35943e5356b4c62d
and
https://github.com/open-telemetry/opentelemetry-swift/pull/809/files#diff-fba1e960fca3f7ad1655e7754ebc8cf1c843a72d3e26620036c551a38311de66