refactored InstrumentBuilder to make relevant builder function public #722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryce-b
requested review from
nachoBonafonte,
vvydier and
ArielDemarco
as code owners
bryce-b
force-pushed
the
refactor-InstrumentBuilder
branch
from
d3513de to
c7275fe
Compare
|
@angelodipaolo would you mind giving this PR a try? |
|
@bryce-b Tested and works great. Thanks for fixing this so quickly! |
bryce-b
force-pushed
the
refactor-InstrumentBuilder
branch
from
c7275fe to
8b0ba9c
Compare
nachoBonafonte
approved these changes
Mar 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #721
a 'virtual' protocol is not viable in this situation because the member variables and extension functions need variable visibility, both internal and public