-
Notifications
You must be signed in to change notification settings - Fork 194
Add baggage span processor #673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add baggage span processor #673
Conversation
The macOS tests look like they might be flaky but the linux test result is for my new tests will poke around and try to find the cause |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you change it to a more expressible naming, it looks very generic like this
It also would need proper documentation in the source code for the future users, for the rest it LGTM
From the sync, naming wise we will go |
2472eb4
to
caef819
Compare
Updated with the following changes:
I left the contrib tests as a single test target but we could break those up into individual test targets too if we think it is worth it? |
I think the only remaining question now is wether we want to have all the contrib tests in one test target or also have many test targets for each piece of contrib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to e, I don't mind having the contribution tests under the same test target or separated
Adds a baggage span processor as per the other contrib repositories.
This processor takes items from the baggage and adds the items as attributes on spans.
Eg. open-telemetry/opentelemetry-go-contrib#5404