Add Request Context to URLSessionInstrumentation Baggage Provider #649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batuhansk
requested review from
nachoBonafonte,
bryce-b and
vvydier
as code owners
|
@nachoBonafonte Could you please retrigger the iOS tests? (it got stuck and ended up after 360 mins) |
|
Hi @nachoBonafonte, has there been a chance to review this MR? Please let me know if there’s anything to address before moving forward. Thanks. |
nachoBonafonte
approved these changes
Jan 2, 2025
|
Hi @nachoBonafonte @vvydier , hope you're doing well. Do you have any updates on when the next release of opentelemetry-swift is planned? |
|
Hi @batuhansk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR enhances the
URLSessionInstrumentationbaggage provider by addingURLRequestandSpanparameters to its callback signature. The enhanced provider enables context-aware baggage creation based on request properties and span information, while maintaining compatibility with active baggage merging. This allows for dynamic baggage customization based on request context.