feat: Suppress internal spans by default

[jterapin]

#1502

Description: The aws_sdk instrumentation now suppresses internal spans by default. This ensures that the additional low-level instrumentation does not generate additional costs for customers unknowingly.

The following work has been done to accommodate:

• Deprecated :suppress_internal_instrumentation config
• Introduced a new config, :enable_internal_instrumentation which is set false by default

To enable internal spans, users will have explicitly configure as follows:

OpenTelemetry::SDK.configure do |c|
  c.use 'OpenTelemetry::Instrumentation::AwsSdk', { enable_internal_instrumentation: true }
end

[ericmustin]

Was this or the related Issue discussed at a SIG? seems like i'm missing some context, at the very least I have some ambivalence about multiple config options that do the same thing.

[jterapin]

Was this or the related Issue discussed at a SIG? seems like i'm missing some context, at the very least I have some ambivalence about multiple config options that do the same thing.

I have not attended SIG so most likely not.

This PR drops the :suppress_internal_instrumentation config entirely in a favor of :enable_internal_instrumentation since the config name is quite explanatory of its default behavior. That being said - I'm fine with just reusing the old config but flipping the config default.

[arielvalentin]

It looks like you are removing this option altogether resulting in a breaking change.

If you want to treat it as deprecated, as opposed to removed, I would recommend leaving the option present and giving precedence to the new option.

[kaylareopelle]

Hi @jterapin, thanks for submitting this PR! I'm with @arielvalentin -- I think we should keep the old config around for a while as a documented deprecated option. Perhaps we could remove it entirely as part of a 1.x release?

What do you think?

[jterapin]

Hello there! Sorry for the late response. Totally agreed!

I'll try to make the suggested change sometime before this week ends.

[github-actions]

👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this pull request will be closed eventually by the stale bot

[github-actions]

👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this pull request will be closed eventually by the stale bot