Skip to content

Add span exporter property to batch span processor #4621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 6, 2025
Merged

Add span exporter property to batch span processor #4621

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ff66806
Add span exporter property to batch span processor
DylanRussell Jun 6, 2025
14c9080
Add test
DylanRussell Jun 6, 2025
7b7d5f0
Merge branch 'main' into add_span_exporter_accessor
DylanRussell Jun 6, 2025
7f5d951
Add changelog
DylanRussell Jun 6, 2025
fac6087
Update CHANGELOG.md
xrmx Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions opentelemetry-sdk/src/opentelemetry/sdk/trace/export/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,11 @@ def __init__(
"Span",
)

# Added for backward compatibility. Not recommended to directly access/use underlying exporter.
@property
def span_exporter(self):
return self._batch_processor._exporter # pylint: disable=protected-access

def on_start(
self, span: Span, parent_context: Context | None = None
) -> None:
Expand Down
5 changes: 5 additions & 0 deletions opentelemetry-sdk/tests/trace/export/test_export.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,11 @@ def test_simple_span_processor_not_sampled(self):
# before the end of the test, otherwise the worker thread will continue
# to run after the end of the test.
class TestBatchSpanProcessor(unittest.TestCase):
def test_get_span_exporter(self):
exporter = MySpanExporter(destination=[])
batch_span_processor = export.BatchSpanProcessor(exporter)
self.assertEqual(exporter, batch_span_processor.span_exporter)

@mock.patch.dict(
"os.environ",
{
Expand Down
Loading