Skip to content

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Aug 13, 2025

Description:
The OpenTelemetryCollector has a dependency in some cases on the TA CRD.

If the TA CRD is not present, the OpenTelemetryCollector controller should be able to continue to perform.

@atoulme atoulme requested a review from a team as a code owner August 13, 2025 23:02
@atoulme atoulme force-pushed the check_ta_availability branch from 597a8a9 to dee90f0 Compare August 13, 2025 23:03
Copy link
Contributor

github-actions bot commented Aug 13, 2025

E2E Test Results

 33 files  ±0  221 suites  ±0   3h 39m 50s ⏱️ - 19m 46s
 85 tests ±0   85 ✅ +1  0 💤 ±0  0 ❌  - 1 
225 runs  ±0  225 ✅ +1  0 💤 ±0  0 ❌  - 1 

Results for commit 6ac8cf2. ± Comparison against base commit 9597117.

♻️ This comment has been updated with latest results.

@atoulme atoulme force-pushed the check_ta_availability branch from dee90f0 to 105ca6a Compare August 14, 2025 00:30
@atoulme atoulme force-pushed the check_ta_availability branch from 105ca6a to 6ac8cf2 Compare August 14, 2025 00:56
@swiatekm
Copy link
Contributor

If we want to do this, we should also check if the TA CRD is present in the collector webook, and return an error if the user enables target allocator in the collector CR. Then, we could also skip the checks during manifest generation. It should not be the case that if the user enables the embedded target allocator, and the CRD isn't present, the operator just ignores it without any output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants