feat(collector): adds spec.hostPID for all collector modes #4280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olandr
commented
Aug 13, 2025
bundle/community/manifests/opentelemetry.io_targetallocators.yaml
Outdated
Show resolved
Hide resolved
atoulme
reviewed
Aug 25, 2025
This adds the field `hostPID boolean` field to the different modes of the collector PodSpec template. - adds hostPID to collector, - adjusts daemonset, deplotment, statefulsets to allow setting hostPID Inspiration for the code follows from the functionality of the `hostNetwork boolean` field --------- on-behalf-of: @SAP Simon Olander ([email protected])
- adds unit and e2e tests - adds .chloggen entry --------- on-behalf-of: @SAP Simon Olander ([email protected])
--------- on-behalf-of: @SAP Simon Olander ([email protected])
olandr
force-pushed
the
feat/allow-hostpid-support-otelcol
branch
from
4751e3d to
a732ae0
Compare
fields in v1beta1/common.go area for all component types. for now the hostPID support is only for the collector --------- on-behalf-of: @SAP Simon Olander ([email protected])
olandr
commented
Aug 26, 2025
Comment on lines
-7
to
+8
| newName: docker.io/pavolloffay/opentelemetry-operator | ||
| newTag: dev-e6d96f00-1755261473 | ||
| newName: ghcr.io/open-telemetry/opentelemetry-operator/opentelemetry-operator | ||
| newTag: 0.131.0-36-ga732ae06 |
There was a problem hiding this comment.
Also the auto-gen overwriting stuff from #4287. Should this docker image be used or is the auto-gen correct? cc @pavolloffay?
frzifus
reviewed
Aug 28, 2025
| newName: docker.io/pavolloffay/opentelemetry-operator | ||
| newTag: dev-e6d96f00-1755261473 | ||
| newName: ghcr.io/open-telemetry/opentelemetry-operator/opentelemetry-operator | ||
| newTag: 0.131.0-36-ga732ae06 |
There was a problem hiding this comment.
Suggested change
| newTag: 0.131.0-36-ga732ae06 | |
| newTag: 0.131 |
Oh I guess that should be correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
At the moment it is not possible to set the
spec.hostPIDfield for the collector (regardless of type). This change adds a featuregateoperator.security.hostpidthat allows a user to configure thespec.hostPIDfield for the collector.Inspiration for the code follows from the functionality of the
hostNetwork booleanfieldLink to tracking Issue(s): 4214
Testing:
Documentation:
Autogenerated docs from the type defs.
on-behalf-of: @SAP Simon Olander ([email protected])