Add spec.dnsPolicy #4274
Open
Add spec.dnsPolicy #4274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
With the current implementation,
GetDNSPolicyautomatically determines the pod's dnsPolicy, preventing users from specifying custom DNS policies such asdnsPolicy: Default.This PR adds a
spec.dnsPolicyfield to the OpenTelemetryCollector to allow users to specify the DNS policy for collector pods.The
spec.dnsPolicyfield is optional, so it doesn't break existing behavior, though when specified, it takes precedence over the default DNS policy determination.Link to tracking Issue(s):
spec.dnsPolicy#4265Testing:
Documentation:
Just generated