Ability to configure Collector's Service, Headless Service, Monitoring Service and Extension Service #4258
Conversation
sky333999
force-pushed
the
configure-collector-services
branch
2 times, most recently
from
e3cefe7 to
c8a51c7
Compare
| @@ -657,6 +657,7 @@ TMP_DIR=$$(mktemp -d) ;\ | |||
| cd $$TMP_DIR ;\ | |||
| go mod init tmp ;\ | |||
| echo "Downloading $(2)" ;\ | |||
| echo "replace fybrik.io/crdoc => github.com/fybrik/crdoc v0.5.2" >> go.mod ;\ | |||
There was a problem hiding this comment.
fybrik.io domain seems to have expired. So adding a replace temporarily.
Idk why this is a problem just for me. Is is that the go mod cached on the GH runners for the actions?
| @@ -558,6 +558,48 @@ service: | |||
| Annotations: map[string]string{}, | |||
| }, | |||
| }, | |||
| &networkingv1.Ingress{ | |||
There was a problem hiding this comment.
Just a re-ordering since now services are created after the ingress in collector.go.
| @@ -239,6 +239,22 @@ type OpenTelemetryCollectorSpec struct { | |||
| // +optional | |||
| ServiceName string `json:"serviceName,omitempty"` | |||
|
|
|||
| // Service to override configuration of the generated Collector Service. | |||
| // +optional | |||
| Service ServiceSpec `json:"service,omitempty"` | |||
There was a problem hiding this comment.
there's no need to edit the v1alpha1 resources, these are deprecated and we shouldnt be touching them anymore.
There was a problem hiding this comment.
Sounds good. I can revert the changes and remove the changes to the converter as well.
sky333999
force-pushed
the
configure-collector-services
branch
from
520d45d to
ec2bfc3
Compare
E2E Test Results 33 files ±0 223 suites +2 4h 4m 20s ⏱️ + 19m 46s For more details on these failures, see this check. Results for commit 5771abd. ± Comparison against base commit 531de9c. |
# Conflicts: # bundle/community/manifests/opentelemetry-operator.clusterserviceversion.yaml # bundle/openshift/manifests/opentelemetry-operator.clusterserviceversion.yaml
Description:
Disabledinstead ofEnabledsuch that it initializes to false when not set and the behavior stays the same.nilimplies retain old behavior.Link to tracking Issue(s):
spec.observability.metrics.disableMonitoringService#4242Testing:
Unit Testing
Local Testing
Validation: Daemonset is created, all 4 services are created. No observable change in behavior.
Validation: Apply failed complaining the CRD did not recognize the new field. Expected behavior.
Validation: Apply was successful; The ClusterIP service is deleted.
Validation: All 4 services are deleted.
Validation: Only the ClusterIP service is recreated and has the overridden name.
E2E Testing
Documentation: CRDs are self-documenting, no further changes made.