Add CollectorTargetReloadInterval option

[bohub12]

Description:

I've added a new CollectorTargetReloadInterval option that allows configuring how often the Prometheus receiver reloads targets from the target allocator.

Link to tracking Issue(s):

• Resolves: Support configuring "target reload interval" via CRD #4095

Testing:

I've verified in a local Kubernetes cluster that:

• Embedded TargetAllocator
  • If not specified, collectorTargetReloadInterval is 30s (default)
  • If specified, collectorTargetReloadInterval uses the custom value
• TargetAllocator CRD
  • If not specified, collectorTargetReloadInterval is 30s (default)
  • If specified, collectorTargetReloadInterval uses the custom value

[swiatekm]

Thank you for the contribution!

I think you might be overcomplicating this change a bit. You're adding a setting that changes collector behavior, but which happens to be part of a config block the operator generates automatically. It's enough for this setting to be in the Collector CRD, there's no reason to change the TargetAllocator CRD. Does that make sense?

[bohub12]

Thanks for the quick review! 👍

I agree with your suggestion to provide collectorTargetReloadInterval only in the Collector CRD. So I added the option only to the Collector CRD as you mentioned. If there's anything in the code that needs to be fixed, feel free to let me know.

[bohub12]

Hello, @swiatekm! Since some time has passed after I opened the PR, a conflict occurred with the main branch, so I resolved it by rebasing and have committed the changes. Please review it when you get a chance! 😄 Thank you

[swiatekm]

@bohub12 your change looks good to me. Could you rebase on main and run make update to get rid of the conflicts in generated files?