Remove component provider generic type #7606
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
remove-component-provider-generic-type
branch
4 times, most recently
from
696ddc4 to
03ea864
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7606 +/- ##
============================================
- Coverage 89.99% 89.99% -0.01%
+ Complexity 7079 7078 -1
============================================
Files 803 803
Lines 21419 21410 -9
Branches 2086 2086
============================================
- Hits 19276 19267 -9
Misses 1479 1479
Partials 664 664 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
trask
force-pushed
the
remove-component-provider-generic-type
branch
2 times, most recently
from
391e7a6 to
d25ee3c
Compare
trask
commented
Aug 22, 2025
| @@ -106,14 +75,10 @@ void create_OtlpHttpDefaults() { | |||
|
|
|||
| assertThat(exporter.toString()).isEqualTo(expectedExporter.toString()); | |||
|
|
|||
| assertThat(exporter.toString()).isEqualTo(expectedExporter.toString()); | |||
There was a problem hiding this comment.
this is just removing an existing duplicative line
| @@ -216,14 +179,10 @@ void create_OtlpGrpcDefaults() { | |||
|
|
|||
| assertThat(exporter.toString()).isEqualTo(expectedExporter.toString()); | |||
|
|
|||
| assertThat(exporter.toString()).isEqualTo(expectedExporter.toString()); | |||
There was a problem hiding this comment.
this is just removing an existing duplicative line
trask
force-pushed
the
remove-component-provider-generic-type
branch
4 times, most recently
from
c3590d0 to
6c64fe5
Compare
trask
force-pushed
the
remove-component-provider-generic-type
branch
from
6c64fe5 to
5a22503
Compare
breedx-splk
approved these changes
Aug 26, 2025
| OtlpHttpSpanExporter expectedExporter = OtlpHttpSpanExporter.getDefault(); | ||
| OtlpHttpSpanExporter expectedExporter = | ||
| OtlpHttpSpanExporter.getDefault().toBuilder() | ||
| .setComponentLoader(capturingComponentLoader) // needed for the toString() check to pass |
.../test/java/io/opentelemetry/sdk/extension/incubator/fileconfig/CapturingComponentLoader.java
Show resolved
Hide resolved
|
I'm fine with it. Don't know if we want to wait for @jack-berg or ask for forgiveness if he hates the change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generic type makes it awkward to use with
@AutoService, because it requires you to useSuppressWarnings("rawtypes")(some background at google/auto#870), e.g.https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/c7dd76454f5af080a1c385fdb7fda2c6bace68f5/instrumentation/resources/library/src/main/java/io/opentelemetry/instrumentation/resources/internal/ProcessResourceComponentProvider.java#L19-L20
Plus, it doesn't seem like we lose much by removing the generic type (in fact it ends up being slightly less code).