Skip to content

add missing declarative config resource providers #14222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

add missing declarative config resource providers #14222

wants to merge 19 commits into from

Conversation

zeitlinger
Copy link
Member

@zeitlinger zeitlinger commented Jul 10, 2025 •
edited
Loading

Fixes #14081

@zeitlinger zeitlinger self-assigned this Jul 10, 2025
@zeitlinger zeitlinger requested a review from a team as a code owner July 10, 2025 14:37
@zeitlinger zeitlinger mentioned this pull request Jul 10, 2025
Open
@zeitlinger zeitlinger marked this pull request as draft July 11, 2025 07:07
@zeitlinger zeitlinger force-pushed the declarative-config-resource-providers branch from f5600d0 to 6728f62 Compare July 15, 2025 15:22
@zeitlinger zeitlinger marked this pull request as ready for review July 15, 2025 16:09
@zeitlinger zeitlinger moved this from In Progress to Awaiting Review in Declarative Configuration: Java Jul 15, 2025
@zeitlinger
Copy link
Member Author

@laurit please have a look 😄

laurit
laurit reviewed Jul 16, 2025
View reviewed changes
@zeitlinger zeitlinger mentioned this pull request Jul 17, 2025
Draft
@zeitlinger
Copy link
Member Author

@laurit can you check again?

@zeitlinger zeitlinger force-pushed the declarative-config-resource-providers branch from f283f17 to e99c20a Compare July 22, 2025 08:08
@zeitlinger
Copy link
Member Author

@laurit can you check again?

1 similar comment
@zeitlinger
Copy link
Member Author

@laurit can you check again?

@zeitlinger zeitlinger force-pushed the declarative-config-resource-providers branch 2 times, most recently from 78f8138 to 2a610ea Compare August 18, 2025 07:39
@zeitlinger
Copy link
Member Author

@trask can you check again?

trask
trask reviewed Aug 20, 2025
View reviewed changes
@zeitlinger
Copy link
Member Author

@trask I've separated the "extraction" logic (which is re-usable) from the declarative and non-declarative provider interfaces, which should make the code easier to maintain (e.g. to delete the non-declarative classes)

@otelbot-java-instrumentation
Copy link
Contributor

🔧 The result from spotlessApply was committed to the PR branch.

@zeitlinger zeitlinger force-pushed the declarative-config-resource-providers branch from 66b0827 to 27bcee2 Compare August 29, 2025 13:39
@otelbot-java-instrumentation
Copy link
Contributor

🔧 The result from spotlessApply was committed to the PR branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask left review comments

@laurit laurit laurit left review comments

@jaydeluca jaydeluca jaydeluca approved these changes

Assignees

@zeitlinger zeitlinger

Labels
None yet
Projects
Declarative Configuration: Java
Status: Awaiting Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

missing resource providers for declarative config
4 participants
@zeitlinger @trask @laurit @jaydeluca