Skip to content

feat(metric): enhance PeriodicReader with context cancellation cause #7265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat(metric): enhance PeriodicReader with context cancellation cause #7265

wants to merge 1 commit into from

Conversation

flc1125
Copy link
Member

@flc1125 flc1125 commented Aug 28, 2025 •
edited
Loading

ref: #7218

This is just a draft; please do not merge.

@flc1125
refactor(metric): enhance PeriodicReader with context cancellation cause
3a64827 
- Update PeriodicReader to use context.WithCancelCause instead of context.WithCancel
- Modify cancel function to provide a reason for cancellation
- Improve code clarity and maintainability by specifying cancellation cause
@flc1125 flc1125 marked this pull request as draft August 28, 2025 05:26
@codecov Codecov
Copy link

codecov bot commented Aug 28, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.0%. Comparing base (25d0274) to head (3a64827).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #7265     +/-   ##
=======================================
- Coverage   83.0%   83.0%   -0.1%     
=======================================
  Files        265     265             
  Lines      24850   24850             
=======================================
- Hits       20631   20628      -3     
- Misses      3839    3842      +3     
  Partials     380     380
Files with missing lines Coverage Δ
sdk/metric/periodic_reader.go 83.9% <100.0%> (-1.1%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@flc1125
Copy link
Member Author

flc1125 commented Aug 29, 2025

#7218 (comment)

@flc1125 flc1125 closed this Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAlias MrAlias Awaiting requested review from MrAlias MrAlias is a code owner

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@pellared pellared Awaiting requested review from pellared pellared is a code owner

@dmathieu dmathieu Awaiting requested review from dmathieu dmathieu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@flc1125