-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Amortize measurement option allocations #7215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MrAlias
merged 10 commits into
open-telemetry:main
from
MrAlias:amortize-opts-stdouttrace
Aug 26, 2025
Merged
Amortize measurement option allocations #7215
MrAlias
merged 10 commits into
open-telemetry:main
from
MrAlias:amortize-opts-stdouttrace
Aug 26, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With self-observability and without.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7215 +/- ##
=====================================
Coverage 83.0% 83.0%
=====================================
Files 265 265
Lines 24748 24788 +40
=====================================
+ Hits 20541 20582 +41
+ Misses 3832 3831 -1
Partials 375 375
🚀 New features to boost your workflow:
|
dmathieu
approved these changes
Aug 26, 2025
flc1125
approved these changes
Aug 26, 2025
Do not copy the pooled slice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pkg:exporter:stdout
Related to the stdout exporter package
Skip Changelog
PRs that do not require a CHANGELOG.md entry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a performance critical exporter, but it is acting as the foundation for all other self-observability work. We want to ensure performance is considered for all this other work.
metric.attrOpt
to head when on default path (i.e.WithAttributeSet
orWithAttributes
)There are three additional allocations in the self-observability. It appears these are added in the error scenario where we need to dynamically build the attributes that are being recorded.
Benchmarks
Follow-up
semconv
helper packages can be updated to accept some of this complexity (e.g. add aAddSet
method that accepts anattribute.Set
instead of just...attribute.KeyValue
).Alternatives
A cleaner version is found in #7226. That relies on an external
bind
package and the clean up mentioned above.