feat: sdk/trace: span processed metric for simple span processor #7162
+239
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le_span_processor.go
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7162 +/- ##
=====================================
Coverage 82.8% 82.8%
=====================================
Files 265 265
Lines 24896 24944 +48
=====================================
+ Hits 20631 20677 +46
- Misses 3885 3887 +2
Partials 380 380
🚀 New features to boost your workflow:
|
…is already being used in batch span processor
mahendrabishnoi2
requested review from
MrAlias,
XSAM,
dashpole,
pellared,
dmathieu and
flc1125
as code owners
|
For some reason codecov comment is not updated but new code is covered by tests. (https://app.codecov.io/github/open-telemetry/opentelemetry-go/pull/7162) |
MrAlias
reviewed
Aug 16, 2025
sdk/trace/simple_span_processor.go
Outdated
| } | ||
|
|
||
| // configureSelfObservability configures metrics for the simple span processor. | ||
| func (ssp *simpleSpanProcessor) configureSelfObservability() { |
There was a problem hiding this comment.
Please flatten this into the span processor creation function or refactor it to not produce side-effects.
Related:
- separate changelog entry - flatten self observability initialization - reset simpleProcessorIDCounter so tests can be run in parallel and order doesn't matter
- use sync.Pool to amortize allocation for metric attrs
- use sync.Pool to amortize allocation for metric attrs - pass context with span to ensure metric is recorded with correct span context
|
@MrAlias Addressed the comments. Please do another round of review when you can. Thanks. |
| if ssp.selfObservabilityEnabled { | ||
| // Add the span to the context to ensure the metric is recorded | ||
| // with the correct span context. | ||
| ctx := trace.ContextWithSpanContext(context.Background(), s.SpanContext()) |
There was a problem hiding this comment.
Is this the correct way to add span to context given we have ReadOnlySpan in this method instead of Span?
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7004
This PR adds support for experimental
otel.sdk.processor.span.processedmetric in simple span processor.Definition of metric at: https://github.com/open-telemetry/semantic-conventions/blob/v1.36.0/docs/otel/sdk-metrics.md
Experimental metrics are behind a feature flag:
OTEL_GO_X_SELF_OBSERVABILITY