Skip to content

Conversation

@alanwest
Copy link
Member

The attributes gated by EnableConnectionLevelAttributes are required. No other language has offered an option to disable these attributes. Removing EnableConnectionLevelAttributes to simplify things.

@alanwest alanwest requested a review from a team as a code owner December 11, 2024 21:57
@github-actions github-actions bot added comp:instrumentation.mysqldata Things related to OpenTelemetry.Instrumentation.MySqlData documentation Improvements or additions to documentation comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient labels Dec 11, 2024
@codecov
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.38%. Comparing base (71655ce) to head (17ae4ee).
Report is 650 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2414       +/-   ##
===========================================
+ Coverage   73.91%   88.38%   +14.46%     
===========================================
  Files         267        9      -258     
  Lines        9615      439     -9176     
===========================================
- Hits         7107      388     -6719     
+ Misses       2508       51     -2457     
Flag Coverage Δ
unittests-Instrumentation.SqlClient 88.38% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...qlClient/Implementation/SqlActivitySourceHelper.cs 90.16% <100.00%> (ø)
....SqlClient/SqlClientTraceInstrumentationOptions.cs 100.00% <ø> (ø)

... and 270 files with indirect coverage changes

@github-actions github-actions bot removed documentation Improvements or additions to documentation comp:instrumentation.mysqldata Things related to OpenTelemetry.Instrumentation.MySqlData labels Dec 11, 2024
Copy link
Member

@rajkumar-rangaraj rajkumar-rangaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kielek Kielek merged commit da7bb32 into open-telemetry:main Dec 12, 2024
60 checks passed
@alanwest alanwest deleted the alanwest/remove-connection-details-option branch December 12, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants