Fix handling of the %z strptime format.
#29929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`strptime(3)` says that `%z` is "an RFC-822/ISO 8601 standard timezone specification", but the previous code did not allow the string "Z" to signify UTC time, as required by ISO 8601.
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@mx-psi I think I've done that correctly, PTAL |
21 tasks
mx-psi
approved these changes
Jan 4, 2024
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jan 10, 2024
**Description:** `strptime(3)` says that `%z` is "an RFC-822/ISO 8601 standard timezone specification", but the previous code did not allow the string "Z" to signify UTC time, as required by ISO 8601. **Link to tracking Issue:** none **Testing:** Added unit tests for both numeric and "Z" time zones. **Documentation:** none
quentinmit
added a commit
to GoogleCloudPlatform/opentelemetry-operations-collector
that referenced
this pull request
Jan 18, 2024
- Updates `go-nvml` to enable building with Go 1.21 - Enables the `filelogreceiver` - Updates `github.com/open-telemetry/opentelemetry-collector-contrib/internal/coreinternal` to pull in open-telemetry/opentelemetry-collector-contrib#29929
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
strptime(3)says that%zis "an RFC-822/ISO 8601 standard timezone specification", but the previous code did not allow the string "Z" to signify UTC time, as required by ISO 8601.Link to tracking Issue: none
Testing:
Added unit tests for both numeric and "Z" time zones.
Documentation: none