mdatagen: attribute with type `bytes` generates erroneous unit tests

[mmynk]

Component(s)

cmd/mdatagen

What happened?

Description

Defining an attribute in metadata.yaml with bytes type generates unit tests which do not compile. The schema defines bytes as a valid type for an attribute.

However, the unit tests tries to create byte arrays like:

mb.RecordMetric1(ts, bytes("attr1-val")

However, I believe it should be:

mb.RecordMetric1(ts, []byte("attr1-val")

Steps to Reproduce

Define an attribute in metadata.yaml as:

attributes:
  attr1:
    description: An attribute with type bytes
    type: bytes

metrics:
  metric1:
  desciption: A metric
  enabled: true
  sum:
    value_type: int
    monotonic: true
  unit: kg
  attributes:
    - attr1

Expected Result

A compiling unit test

Actual Result

A not compiling unit test

Collector version

v0.90.0

Environment information

Environment

OS: Ubuntu v22.04
Compiler(if manually compiled): go 1.21.3 linux/amd64

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

[github-actions]

Pinging code owners:

• cmd/mdatagen: @dmitryax

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[crobert-1]

Hello @mmynk, I was able to reproduce your bug, and I've filed PR #30106 to resolve it. Thanks for filing!

For context, it looks like this is just now being hit because there are no attributes of type bytes yet.