Skip to content

[Fix] fix opencv waitkey bug in demo scripts #2542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2023
Merged

[Fix] fix opencv waitkey bug in demo scripts #2542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions demo/body3d_pose_lifter_demo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,10 +452,11 @@ def main():

video_writer.write(mmcv.rgb2bgr(frame_vis))

# press ESC to exit
if cv2.waitKey(5) & 0xFF == 27:
break
time.sleep(args.show_interval)
if args.show:
# press ESC to exit
if cv2.waitKey(5) & 0xFF == 27:
break
time.sleep(args.show_interval)

video.release()

Expand Down
9 changes: 5 additions & 4 deletions demo/bottomup_demo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,11 +196,12 @@ def main():

video_writer.write(mmcv.rgb2bgr(frame_vis))

# press ESC to exit
if cv2.waitKey(5) & 0xFF == 27:
break
if args.show:
# press ESC to exit
if cv2.waitKey(5) & 0xFF == 27:
break

time.sleep(args.show_interval)
time.sleep(args.show_interval)

if video_writer:
video_writer.release()
Expand Down
9 changes: 5 additions & 4 deletions demo/topdown_demo_with_mmdet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,11 +261,12 @@ def main():

video_writer.write(mmcv.rgb2bgr(frame_vis))

# press ESC to exit
if cv2.waitKey(5) & 0xFF == 27:
break
if args.show:
# press ESC to exit
if cv2.waitKey(5) & 0xFF == 27:
break

time.sleep(args.show_interval)
time.sleep(args.show_interval)

if video_writer:
video_writer.release()
Expand Down
2 changes: 1 addition & 1 deletion projects/just_dance/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ We provide a Jupyter Notebook [`just_dance_demo.ipynb`](./just_dance_demo.ipynb)
Users can simply run the following command to generate the comparison video:

```shell
python process_video ${TEACHER_VIDEO} ${STUDENT_VIDEO}
python process_video.py ${TEACHER_VIDEO} ${STUDENT_VIDEO}
```

### Gradio
Expand Down