[Fix] Add typehint for DarknetBottleneck
#9591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterH0323
requested review from
BIGWangYuDong
and removed request for
RangiLyu
|
LGTM, thanks for your contribution! Please change the PR tile to the CodeCamp format! Also, it is suggested to finish CodeCamp tasks in this single PR. |
|
Hi @BIGWangYuDong ，我不是 CodeCamp 中 mmdet typehint 的报名成员，我正在为 MMYOLO 提交新算法的开发过程中发现了这个问题，顺手修复提的这个 PR 😄 |
yumion
pushed a commit
to yumion/mmdetection
that referenced
this pull request
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add typehint for
DarknetBottleneckModification
mmdetection/mmdet/models/layers/csp_layer.py