-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: create /features/design-system page with design system tools content #2747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: create /features/design-system page with design system tools content #2747
Conversation
- Hero: swap H1/H3 tags and styling, reorder elements - Benefits: change H3 to H2 for titles, H2 to p for descriptions - Features intro: update H3 to H2, split description text - Features grid: change H3 to H2, H2 to text, reorder to H2-Text-Text structure - FAQ: change H2 to H3 for main title Maintains exact visual styling while fixing semantic HTML structure Co-Authored-By: [email protected] <[email protected]>
- Features grid: change H2 back to H3 for feature titles - FAQ section: change H3 back to H2 for main title Addresses user feedback on semantic tag hierarchy Co-Authored-By: [email protected] <[email protected]>
- Clone features page structure from PR #2744 branch - Add FEATURES_BUILDER route constant - Update hero section with React Visual Builder messaging - Update benefits section with 3 builder-specific benefits - Update features intro and grid with 6 builder features - Update CTA section with builder-specific text - Maintain semantic HTML structure and styling Co-Authored-By: [email protected] <[email protected]>
…icate titles Co-Authored-By: [email protected] <[email protected]>
…ntent - Add new design-system page at /features/design-system route - Update hero section with design system tools messaging - Add 3 benefits: Tailwind/Shadcn Visual Editor, Centralized Globals, Template Import - Update features intro with design system management focus - Add 6 design system features: Asset Management, 1-Click Publish, Component Import, Gradient Picker, AI Animations, Layer Management - Update CTA section with design system specific text - Add FEATURES_DESIGN_SYSTEM route constant Co-Authored-By: [email protected] <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
@@ -158,17 +158,17 @@ var Mr = hl((k5, Lf) => { | |||
m = !0; | |||
if (typeof l != 'function') throw new TypeError(jc); | |||
if (((i = Gf(i) || 0), Wc(t))) | |||
(h = !!t.leading), | |||
((h = !!t.leading), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file has undergone extensive auto-formatting changes (e.g., additional parentheses and comma operator usage). While these changes appear cosmetic, they reduce readability and may risk subtle operator precedence issues. Consider separating formatting-only changes into a dedicated commit and double-check that the logic remains unchanged.
@@ -2827,7 +2832,7 @@ function G0(l) { | |||
(g.parseRulePrelude = 'parseRulePrelude' in h ? Boolean(h.parseRulePrelude) : !0), | |||
(g.parseValue = 'parseValue' in h ? Boolean(h.parseValue) : !0), | |||
(g.parseCustomProperty = | |||
'parseCustomProperty' in h ? Boolean(h.parseCustomProperty) : !1); | |||
'parseCustomProperty' in h ? Boolean(h.parseCustomProperty) : !1)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typographical error: There is an extra closing parenthesis at the end of the line. The assignment to g.parseCustomProperty should not be followed by an extra ')'.
@@ -9823,7 +9838,7 @@ function xh() { | |||
for (let b of r) | |||
if (b.type === 'childList') { | |||
let g = b.target; | |||
b.addedNodes.forEach((e) => { | |||
(b.addedNodes.forEach((e) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typographical error: There is an extraneous opening parenthesis before b.addedNodes.forEach((e) => {
. Please remove the extra '('.
@@ -9884,23 +9899,23 @@ function g4(l) { | |||
let o = t.getAttribute(n); | |||
if (o) l.setAttribute(n, o); | |||
}), | |||
t.remove(); | |||
t.remove()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: There's an extra closing parenthesis on this line. It currently reads "t.remove());" but it seems it should be "t.remove();". Please remove the extra ')' to resolve the issue.
@@ -10211,7 +10226,7 @@ var B; | |||
function t(n) { | |||
throw new Error(); | |||
} | |||
(l.assertNever = t), | |||
((l.assertNever = t), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an extra opening parenthesis at the beginning of the assignment to l.assertNever
(i.e. ((l.assertNever = t),
). Please verify if the additional '(' is intentional or a typographical error.
@@ -10767,7 +10782,7 @@ class E { | |||
return this._refinement(l); | |||
} | |||
constructor(l) { | |||
(this.spa = this.safeParseAsync), | |||
((this.spa = this.safeParseAsync), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an extra opening parenthesis before this.spa = this.safeParseAsync
. It looks like ((this.spa = this.safeParseAsync),
may have an extra (
. Please double-check if this is intended.
@@ -10961,7 +10976,7 @@ class Gl extends E { | |||
exact: !1, | |||
message: n.message, | |||
}), | |||
t.dirty(); | |||
t.dirty()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typographical Error: There is an extra closing parenthesis. The method call t.dirty());
should likely be t.dirty();
.
} | ||
if (r.minLength !== null) { | ||
if (i.data.length < r.minLength.value) | ||
x(i, { | ||
(x(i, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typographical issue: There is an unnecessary opening parenthesis before "x(i, {". Consider removing the extra parenthesis for consistent syntax.
@@ -12889,7 +12913,7 @@ function sh(l, i = {}, t) { | |||
var K4 = { object: tl.lazycreate }, | |||
W; | |||
(function (l) { | |||
(l.ZodString = 'ZodString'), | |||
((l.ZodString = 'ZodString'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typographical issue: There is an extra opening parenthesis on this line. It should likely be corrected to a single parenthesis (i.e., change ((l.ZodString = 'ZodString'),
to (l.ZodString = 'ZodString'),
).
- Refactor shared components (FeaturesHero, BenefitsSection, FeaturesGridSection, FeaturesIntroSection) to accept content props with fallbacks - Create content management system with TypeScript interfaces for page-specific content - Add new feature pages: /features/ai, /features/builder, /features/prototype, /features/design-system - Extract content from PRs #2742, #2743, #2744, #2746, #2747 into dedicated content files - Preserve original /features page functionality unchanged - Eliminate content bleeding between feature pages while maintaining design consistency Fixes content bleeding issue where changes intended for one feature page affected others due to shared hardcoded components. Co-Authored-By: [email protected] <[email protected]>
@coderabbitai help me understand what's going on with the conflicts here? |
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chainI'll help you understand the conflicts in this PR. Let me check the current state and identify what's causing the issues. 🏁 Script executed:
Length of output: 1713 Let me check the GitHub PR status to see if there are merge conflicts reported on the GitHub interface: 🏁 Script executed:
Length of output: 2510 Now let me check what specific conflicts exist by comparing with the main branch: 🏁 Script executed:
Length of output: 1008 Let me try a different approach to understand the conflicts: 🏁 Script executed:
Length of output: 1028 I see the issue now! Let me examine this more carefully: 🏁 Script executed:
Length of output: 699 Now I understand the issue! Let me check one more thing to confirm: 🏁 Script executed:
Length of output: 814 Perfect! Now I have a clear picture. Let me check the actual differences that are causing conflicts: 🏁 Script executed:
Length of output: 9340 @itsNintu I can now see exactly what's causing the conflicts in PR #2747. Here's the breakdown: 🔍 Root Cause of ConflictsYour PR is in a "CONFLICTING" state because the main branch has evolved significantly since this PR was created, and there are several overlapping changes: 📋 Key Conflicting Changes
🚨 The Core ProblemYour PR modifies shared components to show design-system content, but main has modified those same components to support AI features. This creates merge conflicts because Git can't automatically reconcile these competing changes. ✅ Resolution Options
Would you like me to help you with any of these resolution approaches? |
Description
Creates a new
/features/design-system
page focused on design system management tools. This page follows the same pattern as other feature pages by cloning the page structure and updating shared components with design-system specific content.Key Changes:
/features/design-system
route with React import and proper setupFEATURES_DESIGN_SYSTEM
route constantRelated Issues
This work was requested by @itsNintu in Devin session: https://app.devin.ai/sessions/f1ee9cde916c46b7a9c6635f76cb66d8
Type of Change
Testing
/features
- Original features page/features/ai
- AI features page/features/builder
- Builder features page/features/prototype
- Prototype features page/features/design-system
- New design system pageTesting Steps:
Screenshots (if applicable)
Screenshots should be added after testing the deployed preview URL
Additional Notes
Auto-formatting: Large portions of the diff contain auto-formatting changes from
bun format
that don't affect functionality but make the diff harder to review.Content Review Needed: All content was provided by the user and should be reviewed for accuracy, tone, and alignment with product messaging.
Requested by: @itsNintu
Devin Session: https://app.devin.ai/sessions/f1ee9cde916c46b7a9c6635f76cb66d8
Important
Adds a new
/features/design-system
page with design system tools content, updating shared components and requiring testing of all feature pages./features/design-system
page with design system tools content.FeaturesHero
,BenefitsSection
,FeaturesIntroSection
,FeaturesGridSection
,CTASection
, andFAQSection
components.features-hero.tsx
with design system messaging.benefits-section.tsx
with design system content.features-grid-section.tsx
with 6 design system features.features-intro-section.tsx
with design system focus.FEATURES_DESIGN_SYSTEM
route constant./features
,/features/ai
,/features/builder
,/features/prototype
, and/features/design-system
pages.This description was created by
for a773b48. You can customize this summary. It will automatically update as commits are pushed.