Alter the url formatting for replication #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-by default it adds /replication/minute but that doesn't work with the .fr mirro
dschep
reviewed
Jan 19, 2024
| "time" | ||
|
|
||
| "github.com/paulmach/osm" | ||
| "github.com/onXmaps/osm" |
There was a problem hiding this comment.
hmm, do we have other refrences to paulmach/osm? I imagine so given that this didn't result in a change to the go.mod file
There was a problem hiding this comment.
oh, just now realied this wasn't the geosore repo 🤦
There was a problem hiding this comment.
but! thi sshouldn't be necessary. because we use: a replace directive in the go.mod https://github.com/onXmaps/osm/blob/master/go.mod#L6
There was a problem hiding this comment.
should I take that change out? I did it because I was using a pinned commit sha
dschep
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by default it adds /replication/minute but that doesn't work with the .fr mirror because it uses the location in the path.
osm.change import updated to refer to this repo