feat: Add extra token request params for authorization code flow #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bufferoverflow Maybe you can check if this is the way to go :-) |
Ok, I was wrong, with |
|
@bufferoverflow Anything missing to bring this forward? :-) |
bufferoverflow
approved these changes
Mar 6, 2025
|
Hi @stanhu Any news here? I think it's waiting on final review or? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the PR I improved the related test case.
I wrongly thought that theclient_idneeds also to be added, but this is already done in the rack oauth2 client.With this e.g. the usage of Auth0 would also work out-of-the-box with this gem.