add +/- annotations to jobs builtin #2042
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andychu
reviewed
Aug 5, 2024
There was a problem hiding this comment.
Thanks!
I wonder if we can add a spec test like
$ bin/osh -c 'sleep 0.01 & sleep 0.02 & sleep 0.03 & jobs'
%1 3423 Running [subprog] command.Simple
%2 3424 Running [subprog] command.Simple
%3 3425 Running [subprog] command.Simple
(Although we really need to print code correctly)
...
I also noticed the pipeline case is a bit weird
we are not printing a job num
$ bin/osh -c 'sleep 0.1 | wc -l & jobs'
3440 Running [subprog] command.Simple
bash and zsh do
$ bash -c 'sleep 0.1 | wc -l & jobs'
[1]+ Running sleep 0.1 | wc -l &
core/process.py
Outdated
| @@ -1777,9 +1777,17 @@ def DisplayJobs(self, style): | |||
| # 24510 | sleep 5 & | |||
|
|
|||
| f = mylib.Stdout() | |||
| current, previous = self.GetCurrentAndPreviousJobs() | |||
| for job_id, job in iteritems(self.jobs): | |||
| # Use the %1 syntax | |||
There was a problem hiding this comment.
this comment can move to _DisplayJob()
core/process.py
Outdated
| for job_id, job in iteritems(self.jobs): | ||
| # Use the %1 syntax | ||
| job.DisplayJob(job_id, f, style) | ||
| extra = '' |
There was a problem hiding this comment.
I think it should default to one space so it's aligned?
|
Let me see about adding a spec test |
|
Hm I think we should land this? Let me look at what happened |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small quality of life improvement for job control. @andychu brought this up in https://oilshell.zulipchat.com/#narrow/stream/121540-oil-discuss/topic/Job.20control.20hard.20to.20understand