[IMP] use file_path and file_open #135607
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mart-e
force-pushed
the
master-deprecate-module-paths-mat
branch
27 times, most recently
from
f4c7812 to
923703f
Compare
mart-e
changed the title
mart-e
force-pushed
the
master-deprecate-module-paths-mat
branch
from
5710352 to
2b04e14
Compare
|
@robodoo r+ (hoping no longer having conflicts) |
|
@mart-e linked pull request(s) odoo/enterprise#47475, odoo/upgrade#5187 not ready. Linked PRs are not staged until all of them are ready. |
mart-e
force-pushed
the
master-deprecate-module-paths-mat
branch
from
2b04e14 to
1041c39
Compare
Replace all the calls to get_resource_path to the better file_path or directly use file_open when not needed Doing both a get_resource_path and file_open means checking twice that the file exists. Doing a simple path concatenation before a file_open is safe. If given to another method (e.g. etree.parse), calling file_path is the prefered method. Note that get_resource_path used to return False when the file does not exists while file_path/file_open raises a FileNotFoundException
mart-e
force-pushed
the
master-deprecate-module-paths-mat
branch
from
1041c39 to
d341891
Compare
|
@robodoo r+ 🙄 |
robodoo
pushed a commit
that referenced
this pull request
Oct 6, 2023
file_path is superior and can replace every (often unnecessary) calls Merge check_resource_path that is no longer needed Part-of: #135607
robodoo
pushed a commit
that referenced
this pull request
Oct 6, 2023
Replace all the calls to get_resource_path to the better file_path or directly use file_open when not needed Doing both a get_resource_path and file_open means checking twice that the file exists. Doing a simple path concatenation before a file_open is safe. If given to another method (e.g. etree.parse), calling file_path is the prefered method. Note that get_resource_path used to return False when the file does not exists while file_path/file_open raises a FileNotFoundException closes #135607 Related: odoo/upgrade#5187 Related: odoo/enterprise#47475 Signed-off-by: Martin Trigaux (mat) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Jun 23, 2024
closes #135607 Signed-off-by: Martin Trigaux (mat) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Jun 23, 2024
closes #135607 Signed-off-by: Martin Trigaux (mat) <[email protected]>
Salvio93
pushed a commit
to Salvio93/Hoot-Integration
that referenced
this pull request
May 22, 2025
Replace all the calls to get_resource_path to the better file_path or directly use file_open when not needed Doing both a get_resource_path and file_open means checking twice that the file exists. Doing a simple path concatenation before a file_open is safe. If given to another method (e.g. etree.parse), calling file_path is the prefered method. Note that get_resource_path used to return False when the file does not exists while file_path/file_open raises a FileNotFoundException closes odoo/odoo#135607 Related: odoo/upgrade#5187 Related: odoo/enterprise#47475 Signed-off-by: Martin Trigaux (mat) <[email protected]>
|
Hello @mart-e |
|
@Armin-FalDiS can you be a bit more specific? This commit changed a lot of things and was merged 2 years ago. edit: oh I see, the ir_ui_menu.py part. Hmm it’s unintentional. We only have .png icons but we could support other image format if needed. Don’t hesitate to make a PR to patch this. |
This was referenced Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate the usage of
get_resource_path/get_module_resource. Usingfile_pathhas the same features with additional security checks.Replace all the deprecated calls to
openorget_resource_pathwith thefile_openandfile_pathmethod.Differences between
get_resource_pathandfile_path:get_resource_pathreturns False if the file does not exsits,file_pathraises aFileNotFoundErrorfile_pathensures the file is within the addons-pathDifference between
openandfile_openfile_openensures the file is within the addons-path