Document that clientId may be assigned to the appId property

[joebowbeer]

There are two places in the README that should mention that the clientId string can be assigned to the appId property, whose type is now number | string. In fact, providing the clientId string is now recommended.

1. https://github.com/octokit/auth-app.js/tree/main?tab=readme-ov-file#createappauthoptions-or-new-octokit-auth-
2. https://github.com/octokit/auth-app.js/tree/main?tab=readme-ov-file#json-web-token-jwt-authentication-1

Originally posted by @gr2m in #606 (comment)

[github-actions]

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

[CMCDragonkai]

I just tried putting the app client ID for the appId, and the error I get on 6.1.4 is:

Error: [@octokit/auth-app] appId option must be a number or numeric string

[gr2m]

@CMCDragonkai I was not able to reproduce the problem with this code

import { createAppAuth } from "@octokit/auth-app";

const auth = createAppAuth({
  appId: 'Iv23ct7ycNNTMv43gXI7',
  privateKey: PRIVATE_KEY,
});

console.log(await auth({
    type: "app",
}))

console.log(await auth({
    type: "installation",
    installationId: 79966063,
}))

It does not log the error. The error code is not even in the source code of the latest version any longer:
https://www.npmjs.com/package/@octokit/auth-app?activeTab=code

Is it possible your code pulls in a different version of @octokit/auth-app?

Latest version is 8.0.2. Can you try that?