Remove unneeded call to ls in nvm_arch
#3012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the call to `ls` that was used to determine the symlink destination Reasoning : * `od` resolves symlink itself due to the use of `fopen` * Prevent the behaviour of `od` which will hang if the filename is empty (i.e. `/sbin/init` missing) as it will be waiting for `stdin` compared to quitting with error if the file just doesn't exist Fixes #3006
ljharb
reviewed
Jan 23, 2023
|
Is there a way to write a test for this? |
|
Don't think so Maybe, to run an install on a |
|
Could we temporarily move |
|
Well, I wouldn't do it though, It's unknown how much breakage can be done by doing that, rendering the test unreliable at best I haven't looked at the test infra here, but using a docker container seems to be by far the easiest |
|
Gotcha - in that case let's merge this without a test. Migrating the tests to use Docker is a good idea, but it'd be a massive project. |
ljharb
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the call to
lsthat was used to determine the symlinkdestination
Reasoning :
odresolves symlink itself due to the use offopenodwhich will hang if the filename isempty (i.e.
/sbin/initmissing) as it will be waiting forstdincompared to quitting with error if the file just doesn't exist
Closes #3006