Skip to content

Conversation

rouzbeh84
Copy link
Contributor

I found the manual install instructions a bit confusing as they sort of jump into a git clone version in the middle of the manual instruction. I don't think you have to do that first line if you have git/go with git but you do have to do the sourcing regardless so I thought this may be a bit easier to understand. thoughts?

- added git as the last method before full manual install.
- added the directory on `git clone` command
- added the `git checkout v0.33.1` as the -v gets updated automatically
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great! Would you mind reordering it so that git goes first? Manually installing the nvm.sh file should be the last resort.

README.markdown Outdated
Or if you have `git` installed (requires git v1.7+):

1. clone this repo in the root of your user profile
- `cd ~/` from anywhere then `git clone https://github.com/creationix/nvm.git`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git clone https://github.com/creationix/nvm.git .nvm so it names the folder properly

README.markdown Outdated

1. clone this repo in the root of your user profile
- `cd ~/` from anywhere then `git clone https://github.com/creationix/nvm.git`
1. check out the latest version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's provide the command here git checkout v0.33.1 (the version number is updated in this file on every release)

Copy link
Contributor Author

@rouzbeh84 rouzbeh84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sent over some updates but forgot to do the review update sorry! Would you prefer to just stick to these suggestions?

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@ljharb ljharb merged commit 0f25994 into nvm-sh:master Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants