-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
manual install update #1490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manual install update #1490
Conversation
- added git as the last method before full manual install. - added the directory on `git clone` command - added the `git checkout v0.33.1` as the -v gets updated automatically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks great! Would you mind reordering it so that git goes first? Manually installing the nvm.sh
file should be the last resort.
README.markdown
Outdated
Or if you have `git` installed (requires git v1.7+): | ||
|
||
1. clone this repo in the root of your user profile | ||
- `cd ~/` from anywhere then `git clone https://github.com/creationix/nvm.git` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git clone https://github.com/creationix/nvm.git .nvm
so it names the folder properly
README.markdown
Outdated
|
||
1. clone this repo in the root of your user profile | ||
- `cd ~/` from anywhere then `git clone https://github.com/creationix/nvm.git` | ||
1. check out the latest version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's provide the command here git checkout v0.33.1
(the version number is updated in this file on every release)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I sent over some updates but forgot to do the review update sorry! Would you prefer to just stick to these suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
I found the manual install instructions a bit confusing as they sort of jump into a git clone version in the middle of the manual instruction. I don't think you have to do that first line if you have git/go with git but you do have to do the sourcing regardless so I thought this may be a bit easier to understand. thoughts?