Skip to content

Conversation

PeterDaveHello
Copy link
Collaborator

No description provided.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - this looks good, but is there a way we could write a test to ensure that these stay in sync?

bash_completion Outdated
version which'
cache clear-cache deactivate unload
version version-remote which
debug'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i kind of want debug not to autocomplete; there's no reason anybody should be using it except to fill out an issue.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed now.

@PeterDaveHello
Copy link
Collaborator Author

PeterDaveHello commented Mar 30, 2017

I don't know how to write test for it yet, as this is not critical, and we still have many feature lack, maybe can do it later in future.

@ljharb ljharb merged commit 6c24346 into nvm-sh:master Mar 30, 2017
@PeterDaveHello PeterDaveHello deleted the bash_completion branch March 31, 2017 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants