Skip to content

[Doc] Add current version on the top of README #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2016
Merged

[Doc] Add current version on the top of README #1309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Node Version Manager [![Build Status](https://travis-ci.org/creationix/nvm.svg?branch=master)][3]
# Node Version Manager [![Build Status](https://travis-ci.org/creationix/nvm.svg?branch=master)][3] ![nvm version](https://img.shields.io/badge/version-v0.32.1-yellow.svg)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds release overhead, or the risk it will go out of date.

Can you verify that make release will update this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes of course 👍 It'll update this part 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to be very explicit - you have actually ran make release manually and verified that it does update it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct:

$ make TAG=0.123.1 release 
=== Bumping version **0.32.1** to **0.123.1** before committing and tagging:
=== TYPE 'proceed' TO PROCEED, anything else to abort: proceed
nvm.sh
 3131:       nvm_echo '0.123.1'
install.sh
 14:   echo "v0.123.1"
README.markdown
 1: # Node Version Manager [![Build Status](https://travis-ci.org/creationix/nvm.svg?branch=master)][3] [![nvm version](https://img.shields.io/badge/version-v0.123.1-yellow.svg)]
 64: curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.123.1/install.sh | bash
 70: wget -qO- https://raw.githubusercontent.com/creationix/nvm/v0.123.1/install.sh | bash
 438: wget -qO- https://raw.githubusercontent.com/creationix/nvm/v0.123.1/install.sh | /bin/bash
 469: [2]: https://github.com/creationix/nvm/blob/v0.123.1/install.sh
package.json
 3:   "version": "0.123.1",
[master de1f255] v0.123.1
 4 files changed, 8 insertions(+), 8 deletions(-)


## Table of Contents

Expand Down