fixed #1278, use backslash in case of overridden dot #1279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ranqiangjun which shells have you tested the resulting profile lines on? |
ljharb
added
needs followup
|
bash and zsh tested. |
|
I'm most concerned about dash, sh, and ksh - would you mind testing those too? |
|
Alternatively, modify all of the test files that source nvm.sh to use |
ljharb
removed
the
needs followup
PeterDaveHello
added a commit
to PeterDaveHello/nvm
that referenced
this pull request
Nov 24, 2016
PeterDaveHello
added a commit
to PeterDaveHello/nvm
that referenced
this pull request
Nov 24, 2016
ljharb
pushed a commit
to PeterDaveHello/nvm
that referenced
this pull request
Nov 25, 2016
edwmurph
pushed a commit
to edwmurph/nvm
that referenced
this pull request
Apr 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ljharb Please review this PR. Thanks!