Skip to content

Revert %s-formatting for SOURCE_STR when writing to shell profile #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2016
Merged

Revert %s-formatting for SOURCE_STR when writing to shell profile #1210

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,9 +281,9 @@ nvm_do_install() {
echo "=> Append the following lines to the correct file yourself:"
command printf "${SOURCE_STR}"
else
if ! command grep -qc '/nvm.sh' "${NVM_PROFILE}"; then
echo "=> Appending source string to ${NVM_PROFILE}"
command printf "%s" "${SOURCE_STR}" >> "${NVM_PROFILE}"
if ! command grep -qc '/nvm.sh' "$NVM_PROFILE"; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do the curlies make a difference? or are you just reverting the whole commit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The curlies don't matter -- either syntax is legit.

echo "=> Appending source string to $NVM_PROFILE"
command printf "$SOURCE_STR" >> "$NVM_PROFILE"
else
echo "=> Source string already in ${NVM_PROFILE}"
fi
Expand All @@ -300,7 +300,7 @@ nvm_do_install() {
nvm_reset

echo "=> Close and reopen your terminal to start using nvm or run the following to use it now:"
command printf "%s" "${SOURCE_STR}"
command printf "$SOURCE_STR"
}

#
Expand Down