Handle testify errors when returned as a callstack #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests are probably gonna fail for this PR. How do I run the tests? |
This was referenced May 10, 2023
akarl
reviewed
May 11, 2023
lua/neotest-go/init.lua
Outdated
Comment on lines
223
to
245
| if file_id ~= nil then | ||
| -- when executing a function there may be no file_id | ||
| results[file_id].status = test_statuses.fail | ||
| end |
There was a problem hiding this comment.
I think file_id is always nil here? So I think that the if statement can be removed completely.
There was a problem hiding this comment.
I've seen this value to be nil when executing a t.Run test function.
|
@sergii4 thanks for the tip. The tests pass and this is ready for review. |
|
Hi @zankich, sorry for late response. Could you please navigate me what issue this PR fixes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While taking a look at #47 I noticed that the testify output wasn't correctly being parsed which may have contributed to the nil reference error.
Testify will reports errors with the format:
and
This PR fixes the nil exception and also returns the test diagnostics for failed tests using testify.