Logical conditions (e.g., || or &&),

[Praczet]

Contributing guidelines

• I have read CODE_OF_CONDUCT.md

Module(s)

mini.ai

Question

Hi,
First of all. Thank you for this plugin. I think this is the most used / useful plugin for me.

Is it possible to operate (remove, select, copy) on the logical condition:
for example in line:

// cursor positioned on selectedMimes
if (this.form.isDirty() || selectedMimes.length > 0) { } 

pressing: dax will remove "sentence" || selectedMimes.length > 0

// after deletion...
if (this.form.isDirty()) { } 

or maybe it can be done by custom_textobjects

Thank you.

[echasnovski]

Thanks for kind words!

Yes, this should be possible, but to what actual extent depends on the effort.

I think the most promising way of doing that would be to use textobjects based on tree-sitter, which requires creating own captures in 'after/queries//textobjects.scm' and use them later in gen_spec.treesitter().

A slightly more straightforward way would be to use Lua patterns and construct a custom textobject according to specification.

Even more straightforward (yet limited) approach would be to reuse gen_spec.argument() with "||" and "&&" as separators. The problem is that they both can't be used inside single custom textobject (Lua patterns don't allow alteration of strings, only characters) without side effects. So the setup can be like this:

local ai = require('mini.ai')
ai.setup({
  custom_textobjects = {
    -- `ax` will remove "||" part, but not "&&"
    x = ai.gen_spec.argument({ brackets = { '%b()' }, separator = '%s*||%s*' }),
    -- `aX` will remove "&&" part, but not "||"
    X = ai.gen_spec.argument({ brackets = { '%b()' }, separator = '%s*&&%s*' }),
  },
})

The alternative would be to allow it to also match "|&" and "&|" strings as another "logical operators". As those are rare, I'd consider it a worthy compromise. So the setup is like this:

local ai = require('mini.ai')
ai.setup({
  custom_textobjects = {
    x = ai.gen_spec.argument({ brackets = { '%b()' }, separator = '%s*[|&][|&]%s*' }),
  },
})

Notes:

• It should ignore separators from inside common brackets and quotes, but I feel that it is what is expected.
• Be careful to not use textobject with cursor on separator or whitespace around it. The behavior is undefined in this case (either left or right part will be selected, depending on its width).

Hope this helps.

[Praczet]

Hi,

Thank you for the replay.
I tried gen_spec.argument() as you suggested and for my needs it works perfectly.

Thanks