Skip to content

Conversation

@larbish
Copy link
Contributor

@larbish larbish commented Jul 22, 2022

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Add an option disableCache to use eventHandler instead of cachedEventHandler.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@larbish larbish requested a review from Tahul July 22, 2022 13:46
@Tahul
Copy link
Contributor

Tahul commented Jul 22, 2022

LGTM ; but I think it would be more appropriate to keep using cachedEventHandler in all production cases with improvements on query hashing.

@Tahul Tahul merged commit 6499767 into main Jul 22, 2022
@Tahul Tahul deleted the feat/disable-cache branch July 22, 2022 14:10
Copy link
Contributor Author

larbish commented Jul 22, 2022

Totally agree but I didn't find a way to do it with the cachedEventHandler options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants