- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 5
feat(module): override github repo by query #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3b11b75    to
    b717b5d      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I need put some work on components, the reactivity should work properly, and I think we could profit from >rc.5 and try using useAsyncData without ids.
I think there is conflicts when you have more than one component of the same type in a same page.
Other than that I love the features you added, these are great improvements to the GitHub module, maybe we could consider on making it a @nuxtjs module at some point?
| TODO: 
 | 
β¦ark-github on readme & realease
| 
 Done in f78fb92 | 
| @larbish ; needs your review :) I added missing tasks and cleaned up some parts of the module. Also updated the docs, that needs review too! | 
| @atinux ; what would you think of moving this under nuxt-community ? This now has a serious lot of different possible usages now and is used in both Docus and Nuxt.com projects :) | 
π Linked issue
Partial resolution of nuxt/nuxt.com#673
β Type of change
π Description
Merge all configurations at the root in
nuxt.config.tsBecomes:
And to avoid middleware route creation for collaborators or release:
This new configuration syntax allow to override the config for all components using the query props:
A new component
GithubReadmehas also been added:π Checklist