NUnit2007 could flag typeof() as a constant first parameter

[stevenaw]

Consider the following code. 0 is a compile-time constant and typeof(TestAnalyzer) is a runtime constant, but passing a runtime constant like typeof() as the actual is still likely an indicator of misuse. The analyzers don't currently identify cases like this but it might be helpful to extend them to catch it.

[Test]
public void Test1()
{
    var result = new TestAnalyzer();

    Assert.That(typeof(TestAnalyzer), Is.EqualTo(result.GetType()));
    Assert.That(0, Is.EqualTo(result.RowVersion));
}

public class TestAnalyzer
{
    public Guid Id { get; set; } = Guid.Empty;
    public int RowVersion { get; set; } = 0;
}

[mikkelbu]

I guess we could extend the analyzer to cover the constants we can use in C# attributes:

• Primitive Constant Values
• string Constants
• typeof(...)
• nameof(...)`
• Enum constants
• Arrays of constant expressions (perhaps this is too difficult)

I'm unsure how many of these we already cover, but it should it should be possible to add most of these

[mikkelbu]

It seems like we cover all of above cases except for typeof(...) and arrays of constant expressions, but I've only fixed the former as the second could be complicated (depending on how general we want the fix to be)