Drop the dependency on ansicolors #822
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package is not actively maintained (last released in 2017), and the function we use is just based on a single simple regular expression. Copy the regular expression into papermill and drop the external dependency.
This may not be terribly important, as the re module caches patterns, but it doesn’t hurt. Corresponds to jonathaneunice/colors#2.
|
There are various CI failures; I didn’t see any that looked related to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The
ansicolorspackage is not actively maintained (last released in 2017), and the function we use is just based on a single simple regular expression. Copy the regular expression intopapermilland drop the external dependency.