Skip to content

Conversation

@smorimoto
Copy link

This PR fixes the problem found by #358 (though it's hardly a problem).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8a1e162 on smorimoto:remove-useless-regex-char-escape into 093b40f on npm:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8a1e162 on smorimoto:remove-useless-regex-char-escape into 093b40f on npm:master.

@lukekarrys
Copy link
Contributor

The escape is useless, but the fix should be to add another \ so the resulting regex only matches a literal . and not any character. I implemented this in #432.

@lukekarrys lukekarrys closed this Feb 26, 2022
@smorimoto smorimoto deleted the remove-useless-regex-char-escape branch February 26, 2022 14:01
@smorimoto
Copy link
Author

@lukekarrys Brilliant!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants