Skip to content

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 16, 2024

Bumps @npmcli/template-oss from 4.22.0 to 4.23.0.

Release notes

Sourced from @​npmcli/template-oss's releases.

v4.23.0

4.23.0 (2024-06-27)

Features

Bug Fixes

Dependencies

Chores

Changelog

Sourced from @​npmcli/template-oss's changelog.

4.23.0 (2024-06-27)

Features

Bug Fixes

Dependencies

Chores

Commits
  • 9acf69e chore: release 4.23.0 (#445)
  • 8252fb2 deps: bump release-please from 16.10.2 to 16.12.0 (#452)
  • b07d17a chore: add .git-blame-ignore-revs for initial prettier (#448)
  • b35bca5 fix: run prettier
  • 210247e chore: add prettier:true to template-oss config
  • 60ee94f feat: add prettier support
  • 8aef509 fix: dont conclude checks if they were never set (#446)
  • 9440c4f fix: pass releases to publish check (#444)
  • 1a073e4 chore: bump @​npmcli/template-oss to 4.22.0
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [@npmcli/template-oss](https://github.com/npm/template-oss) from 4.22.0 to 4.23.0.
- [Release notes](https://github.com/npm/template-oss/releases)
- [Changelog](https://github.com/npm/template-oss/blob/main/CHANGELOG.md)
- [Commits](npm/template-oss@v4.22.0...v4.23.0)

---
updated-dependencies:
- dependency-name: "@npmcli/template-oss"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner July 16, 2024 20:29
@dependabot dependabot bot added the Dependencies Pull requests that update a dependency file label Jul 16, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 17, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@hashtagchris
Copy link
Contributor

@dependabot reopen

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/main/npmcli/template-oss-4.23.0 branch July 17, 2024 03:11
@dependabot dependabot bot reopened this Jul 17, 2024
@dependabot dependabot bot restored the dependabot/npm_and_yarn/main/npmcli/template-oss-4.23.0 branch July 17, 2024 03:11
@hashtagchris hashtagchris force-pushed the dependabot/npm_and_yarn/main/npmcli/template-oss-4.23.0 branch from 335ce58 to ef85b08 Compare July 17, 2024 03:13
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/main/npmcli/template-oss-4.23.0 branch July 17, 2024 03:13
@hashtagchris
Copy link
Contributor

@dependabot reopen

@dependabot dependabot bot restored the dependabot/npm_and_yarn/main/npmcli/template-oss-4.23.0 branch July 17, 2024 03:13
@dependabot dependabot bot reopened this Jul 17, 2024
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/main/npmcli/template-oss-4.23.0 branch July 17, 2024 15:02
@hashtagchris
Copy link
Contributor

@dependabot reopen

@dependabot dependabot bot reopened this Jul 17, 2024
@dependabot dependabot bot restored the dependabot/npm_and_yarn/main/npmcli/template-oss-4.23.0 branch July 17, 2024 15:03
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/main/npmcli/template-oss-4.23.0 branch July 17, 2024 15:06
@hashtagchris
Copy link
Contributor

@dependabot reopen

@dependabot dependabot bot restored the dependabot/npm_and_yarn/main/npmcli/template-oss-4.23.0 branch July 17, 2024 15:06
@dependabot dependabot bot reopened this Jul 17, 2024
hashtagchris added a commit to npm/template-oss that referenced this pull request Jul 17, 2024
<!-- What / Why -->
<!-- Describe the request in detail. What it does and why it's being
changed. -->

`steps.metadata.outputs.directory` is set to `/main`, not `/`, when
`package.json` is at the root of the repository. I suspect adding
`target-branch` to `dependabot.yml` (#330) added a `main` segment to
Dependabot PR branch names, which changed the value of
`steps.metadata.outputs.directory`.

By fixing this issue, we shouldn't need to routinely use stafftools to
fix up template-oss Dependabot PRs. 🤞🏼

I couldn't quickly find a `bump @npmcli/template-oss` Dependabot PR for
a workspace to inspect `steps.metadata.outputs.directory` and fix
workspaces support. If that's important, we may want to either enable
Dependabot for `npm/cli` or create a separate `template-oss-test` repo.
It's not clear if Dependabot will create a PR for
`workspace/test-workspace` upon our next release.

### Example Dependabot PR branch names

The first PR updates just `@npmcli/template-oss`. The second updates
multiple dependencies including `@npmcli/template-oss`.

PR | branch name | segments | steps.metadata.outputs.directory
-|-|-|-
npm/agent#110 |
`dependabot/npm_and_yarn/main/npmcli/template-oss-4.23.0` | 5 | `/main`
npm/statusboard#877 |
`dependabot/npm_and_yarn/main/dependency-updates-4de8b5bfcf` | 4 | `/`

## References
<!-- Examples:
  Related to #0
  Depends on #0
  Blocked by #0
  Fixes #0
  Closes #0
-->

Failed "Post Dependabot" run:
https://github.com/npm/agent/actions/runs/9963674341/job/27530225303

Fix manually tested here:
npm/agent@ef85b08


[branchNameToDirectoryName](https://github.com/dependabot/fetch-metadata/blob/ffa2dc8ffecf17d26f6a81b83f9ef5edd33ba93a/src/dependabot/update_metadata.ts#L31)

Bug report: dependabot/fetch-metadata#540
@hashtagchris hashtagchris force-pushed the dependabot/npm_and_yarn/main/npmcli/template-oss-4.23.0 branch from 771dbba to ae99213 Compare July 17, 2024 15:11
@hashtagchris
Copy link
Contributor

@dependabot reopen

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/main/npmcli/template-oss-4.23.0 branch July 17, 2024 15:13
@dependabot dependabot bot reopened this Jul 17, 2024
@dependabot dependabot bot restored the dependabot/npm_and_yarn/main/npmcli/template-oss-4.23.0 branch July 17, 2024 15:14
@hashtagchris hashtagchris force-pushed the dependabot/npm_and_yarn/main/npmcli/template-oss-4.23.0 branch from ae99213 to ef85b08 Compare July 17, 2024 15:16
@hashtagchris
Copy link
Contributor

@dependabot reopen

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/main/npmcli/template-oss-4.23.0 branch July 17, 2024 15:16
@dependabot dependabot bot reopened this Jul 17, 2024
@dependabot dependabot bot restored the dependabot/npm_and_yarn/main/npmcli/template-oss-4.23.0 branch July 17, 2024 15:16
@hashtagchris
Copy link
Contributor

@dependabot recreate

Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 17, 2024

Superseded by #111.

@dependabot dependabot bot closed this Jul 17, 2024
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/main/npmcli/template-oss-4.23.0 branch July 17, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants