refactor: download archive page unnecessary checks #8134
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the download archive page by removing unnecessary validation checks and error handling that are deemed redundant given the context of how the page is accessed. The changes include simplifying the version extraction logic and updating the UI to provide more prominent links to version-specific information.
- Simplified
extractVersionFromPathfunction by removing null checks and version format validation - Removed error handling in
WithDownloadArchivecomponent that was checking for null versions - Added changelog and blog post links higher up in the archive page UI
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
apps/site/util/download/archive.tsx |
Simplified version extraction by removing validation checks and making the parameter non-optional |
apps/site/components/withDownloadArchive.tsx |
Removed null checks, unused imports, and simplified version matching logic |
apps/site/pages/en/download/archive/index.mdx |
Added changelog and blog post links to provide better access to version information |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8134 +/- ##
==========================================
- Coverage 76.60% 76.55% -0.05%
==========================================
Files 115 115
Lines 9595 9602 +7
Branches 321 323 +2
==========================================
+ Hits 7350 7351 +1
- Misses 2244 2250 +6
Partials 1 1 ☔ View full report in Codecov by Sentry. |
|
I'll check why the |
apps/site/redirects.json
Outdated
| @@ -332,6 +332,10 @@ | |||
| "source": "/:locale/download/source-code/current", | |||
| "destination": "/:locale/download/current" | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Since the file (/pages/download/archive/index.mdx) is under the pages directory, it maps to /download/archive (When we remove version control, it drops to 500 page because there is no version named archive). In fact, this file doesn’t really need to live under pages directory
- Store the dynamically generated markdown files in a different directory instead of
pages - Redirect
/download/archiveto/download/archive/current - Use an existing version(eg:
v22.0.0.mdx) as the filename instead ofindex.mdx
IDK wich one suits for us better, for a quick fix i added this redirect 
There was a problem hiding this comment.
ah this will also cause errors at build time 🤔
There was a problem hiding this comment.
IDK, instead of going for an overkill solution, I added back the release check for now
Description
I’ve made some small refactors on the download archive page, per related comments here;
#7794 (comment)
#7794 (comment)
In addition to this PR, I’ve also added the changelog of the displayed version to the section where we provide version-related information. Since this information is valuable, I believe placing the links higher up makes more sense
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.