Skip to content

Conversation

avivkeller
Copy link
Member

Fixes #8100, and fixes a .some to .every

@Copilot Copilot AI review requested due to automatic review settings September 1, 2025 14:11
@avivkeller avivkeller requested a review from a team as a code owner September 1, 2025 14:11
Copy link

vercel bot commented Sep 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Sep 1, 2025 2:12pm

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes ARMv7 compatibility checks by restricting ARMv7 support to versions below 24.0.0 and correcting the semver compatibility logic to require all conditions to be met rather than just any one.

  • Updates ARMv7 compatibility to exclude Node.js 24+ versions
  • Changes semver compatibility check from .some() to .every() for proper logical evaluation

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
apps/site/util/download/index.tsx Changes semver compatibility logic from some to every
apps/site/util/download/constants.json Adds upper bound to ARMv7 semver compatibility

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

codecov bot commented Sep 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.61%. Comparing base (9f16142) to head (910723f).
⚠️ Report is 7 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8130      +/-   ##
==========================================
+ Coverage   76.56%   76.61%   +0.05%     
==========================================
  Files         115      115              
  Lines        9595     9595              
  Branches      322      321       -1     
==========================================
+ Hits         7346     7351       +5     
+ Misses       2248     2243       -5     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avivkeller avivkeller added this pull request to the merge queue Sep 3, 2025
Merged via the queue into main with commit a959ebd Sep 3, 2025
12 checks passed
@avivkeller avivkeller deleted the armv7 branch September 3, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linux ARMv7 release links returns file not found
3 participants