-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
chore: partners/sponsors page #7991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7991 +/- ##
==========================================
- Coverage 76.60% 76.56% -0.05%
==========================================
Files 115 115
Lines 9595 9599 +4
Branches 321 322 +1
==========================================
- Hits 7350 7349 -1
- Misses 2244 2249 +5
Partials 1 1 ☔ View full report in Codecov by Sentry. |
1efa109
to
81522ce
Compare
269d6aa
to
7e19b83
Compare
7e19b83
to
8724b52
Compare
8724b52
to
60f5bfa
Compare
60f5bfa
to
5960304
Compare
I’m reaching out to Kylie on Slack to get the logos of the missing companies, since I couldn’t find the brand kits for some of them or they require permission. |
5960304
to
545c769
Compare
545c769
to
77f675c
Compare
d22e42a
to
d45ec56
Compare
707677c
to
d737364
Compare
…categories and cleaning up content
…moval, and display processes
(v minor nit as I just got the review ping, I feel this PR is more than a "chore" at this point?) |
Okay, I’ve updated the partners based on the ones listed at https://openjsf.org/partners. This removes sections (security, release, and services) and also removes the partners shown in the security blog. I’ve commented that out for now since the requirements described here) mentioned that the security blog should display the partners from that section, but the list Kylie shared only includes those shown on https://openjsf.org/partners.
|
docs/partners.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a blocker until I get time to review this properly.
On Tuesday I’ll fix the conflicts in the PR |
this looks good to me. once we get more details / official signed contracts on partners we can add, we can edit this page. |
@bjohansebas could you rebase? I'm going to give finally a technical review next week! |
Yep, sorry for the delay. Tomorrow is a new month and the Codespaces reset so I can use them. I’ll do the rebase |
Note Your Pull Request seems to be updating Translations of the Node.js Website. Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project. Thank you! |
And well, also fix that linter error — I have no idea why it’s showing up, I’ll look into it over the weekend. |
That lint error is from some changes from Crowdin. Looks like it was introduced in the recent sync |
Description
closes #7909
I’m making changes quite quickly, so the code is not ready for review yet.
Validation
Related Issues
Check List
pnpm format
to ensure the code follows the style guide.pnpm test
to check if all tests are passing.pnpm build
to check if the website builds without errors.