repl: tab completion targets <class> instead of new <class>
#60319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hainenber <[email protected]>
nodejs-github-bot
added
needs-ci
|
hi @Renegade334, sorry for pinging but can you help review this one? I hope everything's up to par with expected quality for a |
Renegade334
reviewed
Oct 20, 2025
lib/internal/repl/completion.js
Outdated
| // we want to extract the callee for completion (e.g. for `new Sample` we want `Sample`) | ||
| if (lastBodyStatement.type === 'ExpressionStatement' && | ||
| lastBodyStatement.expression.type === 'NewExpression' && | ||
| lastBodyStatement.expression.callee.type === 'Identifier') { |
There was a problem hiding this comment.
Is this check necessary? It excludes MemberExpressions (the same logic should apply to new X.Y. as applies to new X.).
There was a problem hiding this comment.
Thanks for the review! I've loosened the condition to only null check the expression.callee properties. This should handle case of new X.Y..
Please take a look when you have time.
Signed-off-by: hainenber <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #60306
I've modified the function
findExpressionCompleteTargetto handle autocompletion fornew <class>code by detecting proper identifiers and re-parse only for<class>identifier instead.Testing